GitLab

Do not declare *_sys_t typedefs globally in vlc_common.h. Instead,
declare them locally in each module that provides a definition.

This paves the way to move C++ definitions into anonymous namespaces in
order to respect C++ ODR.

The picture_resource_t and sout_stream_id_sys_t typedefs will be handled
separately, since they require specific additional changes.

See #18033
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

A combined access-demux cannot be instantiated without an ES output.
This checks that the ES output is present, avoiding crashes for
instance with vlc_stream_NewURL().

This plugin does not need priority since no other plugins have any
alias in common. However, it has also an access submodule, and we want
the access_demux submodule at higher priority for the time being.

This plugin does not need priority since no other plugins have any
alias in common.

Regression from cf4676c1.

In order to avoid confusion with future vlc_alloc.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

(Unfortunately, this does not seem to be actually called.)

The variable value is always zero as of bdc3ad38. Simplify accordingly.

This removes the fake WAVE header, and separates the whole disk
"directory" CDDA sub-module from the track CDDA sub-module.

They have been identical for a while.

pf_read() returns 0 to signify EOF, and -1 to signify no data.
pf_block() returns NULL either way. This flag is added for the
distinction.

It cannot be NULL or empty (the default is typically "file").

Remove "int options, const char *const *options, unsigned option_flags"
arguments from every New() functions since these args are mainly unused. You
now have to call input_item_AddOptions after input item creation to add
options.

Add input_item_net_type enum in order to avoid confusion between 2 int
arguments: i_duration and i_net that could both be -1, 0 or > 0.

Replace input_item_NewWithType and input_item_NewWithTypeExt with
input_item_NewExt.

Add input_item_NewCard, input_item_NewDisc, input_item_NewStream,
input_item_NewDirectory, input_item_NewFile MACRO. These MACROS avoid to use
useless arguments for an item type (for example, it's useless to specify a
duration for a directory type).

Do not add a const qualifier for the p_parent since mutexes operations are not
const. Forgot to invert one call in input_item_Copy.

This reverts commit 1d8338cd, which is
obviously wrong.

Add a const qualifier for the source and make the code less angrrrrrrrry.

If there is a parent input, it cannot go away. There was no point in
reference counting.