GitLab

Do not declare *_sys_t typedefs globally in vlc_common.h. Instead,
declare them locally in each module that provides a definition.

This paves the way to move C++ definitions into anonymous namespaces in
order to respect C++ ODR.

The picture_resource_t and sout_stream_id_sys_t typedefs will be handled
separately, since they require specific additional changes.

See #18033
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

This removes conflicts with the NetBSD headers and libc.
The conflicts caused fatal build errors.

No functional change intended for other Operating Systems.
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Keep the original decoded order to achieve a correct Ambisonics rendering.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Regression from 790d6b1f

heap buffer ofw on no reorder

inverted return codes
should consume init bytes

Previous faad2 contribs fix was incorrect.
Fix has to be done in decoder module.

This reverts commit 85f0e45b.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Rename i_original_channels to i_chan_mode. For now, chan modes can be
DOLBYSTEREO or DUALMONO.

This new value, i_chan_mode, should only be set by demuxes/codecs/packetizers
if there is a special stereo mode to handle.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

It's done when loading the decoder/packetizer.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

This avoids probing video or SPU decoders for audio format and vice-
versa.

Will only workaround the bug for those 7.1 mappings

FAAD can't properly map channels with instance > 2.
This will fix it at least for the FDK setup.

Most blocks contains aligned samples.

Causes out of sync, frame dropping.

Use only one callback for every decoder types:

int (*pf_decode)(decoder_t *, block_t *p_block);

There is now only one way to send output frames/blocks from a decoder module:
using decoder_QueueVideo(), decoder_QueueAudio() and decoder_QueueSub()
functions.

This fixes transcoding not receiving any output when a decoder used
decoder_Queue*() function.

The pf_packetize callback is kept unchanged. A packetizer shouldn't be
asynchronous at all (and this simplify the locking for decoder core).

The pf_decode callback returns, for now, only one value: SUCCESS. This will
allow a module to send more status.

Decoder modules are now responsible for calling decoder_UpdateAudioFormat()
before decoder_NewAudioBuffer().

In a lot of modules, decoder_UpdateAudioFormat() could be called in a better
place. Just after dec->fmt_out is updated for example.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

For now, a lot of decoder/packetizer are also flushing on
BLOCK_FLAG_DISCONTINUITY flag. Some others are also flushing on
BLOCK_FLAG_CORRUPTED flag (omxil, videotoolbox, avcodec audio).

This patch doesn't change the current behavior.
But maybe we shouldn't flush anymore on DISCONTINUOUS/CORRUPTED.

Most of the cases it's enought just to set pts so codec resyncs itself.
Also flushing on discontinue isn't good idea.

This reverts commit 5e36cb2c.

This reverts commit 48a867c7.

Revert for futher checking

If blocks are marked BLOCK_FLAG_DISCONTINUITY then do not drop them,
unless BLOCK_FLAGS_CORRUPTED is set. Instead flush old blocks from decoder
queue and restart at this new stream access point (new timeline).
Signed-off-by: Ilkka Ollakka <ileoo@videolan.org>

Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>