GitLab

Missing some cases that I could not test.
Also ffmpeg/chroma.c is locked, so I can but leave it broken.
Fix is for the remaining modules is obvious and the issue is easy to detect.

Enforce access to input_item_t through input_item_{G,S}et*()
Unlock mutexes before calling these functions
Free strings returned by input_item_Get*()

New functions added:

char * input_item_GetURI( input_item_t  * )
void input_item_SetURI( input_item_t * , char * )

mtime_t input_item_GetDuration( input_item_t * )
void input_item_SetDuration( input_item_t * , mtime_t )

to access input_item_t->psz_uri and input_item_t->i_duration

Added new hotkeys "key-menu-[on|off|left|right|up|down|select]". Lirc now calls the osd_Menu*() functions directly when prefix "menu " followed by one of: on, off, left, right, up, down or select is found.

This also seems to make the pre-existing Qt4 crash more obvious.

Hotkeys: Enable mouse wheel up/down and left/right usage. (mapped respectivly to volume up/down, and position forward/backward). This commit needs review.

found. Should save a few precious cycles

keyevent, rather than execute the last unassigned key action. Fixes an
issue that causes the playback to be unintenionally paused whenever a
modifier is pressed and the qt4 interface has focus (key-pause is not
assigned by default)

'r' -> toggle random
'L' -> toggle normal / repeat one / loop

* Headers in include must contain the structures and prototypes needed
  by the plugins and should be named vlc_*.
* Headers in include/vlc must contain the structures and prototypes
  needed by external libvlc clients

* Moved and renamed some things in headers. 
   - Removed vlc_cpu.h, vlc_error.h (merged in vlc_common)
   - Removed snapshot.h (merged in vlc_vout.h)
   - Removed vlc_spu.h (merged in vlc_osd.h)
   - Removed intf_eject.h and vlc_interaction.h (merged in vlc_interface)
   - Moved all internal headers to src
   - Merged vlc_video.h and video_output.h and move private things to src
   - Removed vlc/intf.h, vlc/aout.h, vlc/vout.h, vlc/decoder.h and vlc/input.h
     (meta headers for use in modules, and often implying too large 
     dependencies)
* Removed some useless dependencies
* Unexported a bunch of functions and structures used only in src/
  (--> Still some work here)
* Finally made input_thread_t and input_source_t (mostly) private. 
  Added input_GetItem to fetch the input_item of an input_thread
* Cleaned up deprecated entries in vlc_symbols.h and bumped up symbol 
  prefix

This commit has a 99% probability of breaking the build, 0.1% of killing
your cat and 0% of getting you hot chicks.

* destroy some mutex'es once in a while to prevent memleaks. Suggested by a forumuser, name pending. 

 - Remove a bunch of transition now-useless API.
 - Remove all playlist_Lock* functions. Matching functions now accept a
   b_locked parameter that should be set to VLC_TRUE if the playlist is
   locked when calling the function. The advantages are that it reduces
   the API bloat and that the b_locked flag can be propagated in the
   call stack
 - Remove useless playlist testsuite
 - Remove broken daap plugin (unmaintained wrt VLC API changes, relies on 
   an unmaintained library, probably unable to read content from new itunes, 
   ...). Implementations exist in rhythmbox, xmms2 and 
   daap-sharp, we should see if a proper lib exists or if we could 
   make one
 - Reduce verbosity a bit
 - Documentation

This array is now usable as a reliable source of data for size
Use playlist_CurrentSize(p_playlist) to retrieve the size of the current playset.

 * Remove the random special case
 * Use the array of currently playing items for all cases
 * Convert array items to array API
 * Replace standard searches in sorted arrays by bsearches
 * Size is not yet fixed (next round).

Array
 * Add reset/value and bsearch functions
 * Add foreach helper

This removes useless wakeups and improves hotkeys reactivity

  p_libvlc->b_die
  Not implemented for OS X as I am not sure, please check if it is feasible.
* Don't run the dummy interface

Also, make it clearer what is shared and instance-specific

So,
libvlc_t ==> libvlc_global_t
vlc_t ==> libvlc_int_t (internal instance)

p_object->p_libvlc ==> p_object->p_libvlc_globale
p_object->p_vlc ==> p_object->p_libvlc

VLC_OBJECT_VLC ==> VLC_OBJECT_LIBVLC

And by the way, there is some cleanup required :) (ie, some things are created in the global object instead of the instance-specific one)

  this needs to be tested

(Remove ITEMPLAY method, which had become redundant)

What is currently broken:
 * Some playlist demuxers (shout, dvb and pls)
 * DAAP
 * BeOS playlist
 * GPE playlist, I suppose

What has some trouble:
 * Meta handling in several demuxers (most notably TS)
 * Skins2 playlist (doesn't refresh correctly)
 * OS X playlist (see bigben's latest commits)

alt+i -> crop one more pixel from the top
alt+j -> crop one more from the left
alt+k -> crop one more from the bottom
alt+l -> crop one more from the right
alt+shift+<the letter> -> crop one less

* Move out Advanced/Misc/Misc options
* Don't show any Stuff/General category anymore
* For interfaces, split out "General" from main interface settings
* Remove dummy from prefs
* Clean hotkeys settings

(Closes:#598)