GitLab

Also emit layoutAboutToBeChanged/layoutChanged() more. Speeds up
playlist-view atleast for me

we don't use per-item showflags anyway, as currently they are all same
on model-wide. And I didn't comeup any use-case currently that would
need per-item showflags.

Set currentItem to NULL if there aren't anything playing on rebuild()

Maybe this would actually works better if we store index, but maybe I'll
look it sometime later why it didn't work as I expected.

This reverts commit 753731a2.

Didn't afterall worked correctly even thought I thought I tested it.

Jakob Leben authored Aug 12, 2009 and Rémi Denis-Courmont committed Aug 13, 2009

Fix segfault when dropping more then one item onto an item in the left side selector.

Also copy instead of move items when dragging from media library to playlist and the opposite.
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

No need to store/recreate metadata on plitem anymore, as we can get
it now on the fly, also separate headerData and Data. Hopefully
that vlc_gc_incref/vlc_gc_decref is sufficient for that input_item_t
pointer protection.

Feel free to fix/revert/comment if that pointer shouldn't really be
there, or if it's not safe it to be there thisway.

Jakob Leben authored Aug 10, 2009 and Jean-Baptiste Kempf committed Aug 12, 2009

This patch fixes the crash when a node is selected together with it's children and then deleted
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Jakob Leben authored Aug 09, 2009 and Rémi Denis-Courmont committed Aug 11, 2009

Drop enabled only inside Playlist and Media player, not Podcast and
other Internet sources...
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Jakob Leben authored Aug 02, 2009 and Rémi Denis-Courmont committed Aug 08, 2009

New protected field bool PLItem::b_is_node to have the data at hand.
Then only check this field in PLModel::flags().
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Jakob Leben authored Aug 02, 2009 and Rémi Denis-Courmont committed Aug 08, 2009

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

This should be more clearer to user what column is used to sort (eg if
it's hidden, then hide sortIndicator also).

Jakob Leben authored Jul 31, 2009 and Rémi Denis-Courmont committed Aug 01, 2009

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

should fix bug #2947 ,now it scrolls to new item when theres actual
input-change, not just data changed.

Besnard Jean-Baptiste authored Jul 22, 2009 and Jean-Baptiste Kempf committed Jul 22, 2009

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

François Cartegnie authored Jun 09, 2009 and Jean-Baptiste Kempf committed Jun 09, 2009

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Fabio Ritrovato authored Mar 13, 2009 and ivoire committed Mar 15, 2009

Signed-off-by: Rémi Duraffort <ivoire@videolan.org>

I hope they will reduce the risk of error until the playlist API is rewritten.

This reverts commit 394a9e2c.

This doesn't really fix the issues, so better to revert and rework it.