GitLab

The outline was too thin and the mini control was actually larger
than the small control for some reason.

The active/disabled bar should not be drawn for Sliders that have
tick marks, as it looks confusing. This commit will make the full
slider bar draw as active, if it has tick marks.

The Slider cell was using the tick mark drawing that the OS provided,
which could cause them to be drawn with dark color on dark background
on older OS X versions.
This commit adds the missing tick mark drawing.

Bar drawing was only working for horizontal cells completely,
this adds bar drawing for the active/inactive parts for vertical
cells as well.

The VLCHUDSliderCell was lacking drawing for the actual bar, this could
cause a weird look on older Mac OS X Versions. This patch adds a first
implementation of bar drawing.

It currently only fully works for horizontal sliders, for vertical
sliders the inactive/active part is ignored and the whole bar is drawn
as active.

This also replaces an assert with a more meaningful error message

With this commit, HTML descriptions in the addons manager
are parsed correctly and formatting is applied using a
NSAttributedString and a little bit of CSS to make it use
the system font.

fix bug where VLC segfaults on OSX: After switching a playlist item
while presented a resume dialog, the resume dialog still shows for
the previous item. Clicking "continue" crashes VLC.
Signed-off-by: David Fuhrmann <dfuhrmann@videolan.org>

This better matches similarly styled macOS dialogs, with the meaning
"just do it and do not annoy me again". Value will be set on click
on the checkbox.

close #17134

This replaces the string comparisons with outlet
pointer comparisons, should speed up things a bit.

Additionally it refactors the the Teletext loop
to use a Objective C iteration.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

It seems the teletext menu item validation special case is not
necessary at all anymore.
If the parent item is disabled, it does not seem to matter if the
subitems are enabled or not, as access to the subitems is not possible
when the parent is disabled.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

This improves label readability in Dark mode and accessibility option
like the high contrast setting by using the default disable/enabled
color.
For some reason, disabled text on menu items still renders slightly
better if the background of the menu is a dark area compared to text
on our custom view in menu items, but using a non-standard text color
has too many downsides compared to this little corner-case readability
problem.

This adds a menu item to open the new renderer dialog
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

This adds a dialog to choose a renderer discovered with VLCRendererDiscovery, this allows for example to render to Chromecast in the future.

Additionally edited the Makefile for the new classes to be compiled.
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

This adds two wrapper classes:

- VLCRendererDiscovery
  Wraps libvlc’s vlc_renderer_discovery and allows a delegate
  to receive add and delete notifications for renderer items.

- VLCRendererItem
  Wraps libvlc’s vlc_renderer_item, is used by VLCRendererDiscovery
  to conveniently wrap the vlc_renderer_item to use them easier in
  Objective C.
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>