GitLab

Hugo Beauzee-Luyssen authored Dec 21, 2009 and Jean-Baptiste Kempf committed Dec 25, 2009

Use the generic singleton for Bookmarks, ErrorsDialog, extended dialog, GotoTime dialog, every help class, MediaInfo, Messages, OpenURL, Playlist, Plugin, Podcast configuration and VLM. Also fix some memleaks when quitting
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Hugo Beauzee-Luyssen authored Dec 21, 2009 and Jean-Baptiste Kempf committed Dec 25, 2009

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

It is non blocking regarding Main Thread.
It is compatible with minimal_macosx in term of drawable-nsobject.
It will only work if a drawable-nsobject is provided.

It removes the glitches there was with minimal_macosx (and gui/macosx) when:
- Displaying the first frames
- Resizing the view.

This is consistent with --help behaviour.

This reverts commit a1ab6ede.
This is not anymore needed with the probe rework.

This reverts commit b2ee1bcf.
This is an ugly and confusing hack.

We could probably expose some function to let the client change that on the fly as well. And/Or fix the logging API.

returning VLC_EGENERIC is no problem, since the vout system is an observer of the change in size and will report the real situation.
returning VLC_SUCCESS is wrong in an asynchronous environmenent, as resizing is only performed later on (or not) depending on GUI configuration.

On the other hand, it allows intf-show to really perform its goal
(react on user interaction via hotkey or mouse)

Revert "Probably fix LoadMessages() on windows. (Untested ... I'm not even sure that the config is initialised when we're called. But that shouldn't matter, we'll just fallback to the default data directory)"

This reverts commit 4c5f93c1.

Probably fix LoadMessages() on windows. (Untested ... I'm not even sure that the config is initialised when we're called. But that shouldn't matter, we'll just fallback to the default data directory)

TODO: Freebox

Maybe we should check the directories do exist first?