GitLab

This also replaces an assert with a more meaningful error message

This replaces the string comparisons with outlet
pointer comparisons, should speed up things a bit.

Additionally it refactors the the Teletext loop
to use a Objective C iteration.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

It seems the teletext menu item validation special case is not
necessary at all anymore.
If the parent item is disabled, it does not seem to matter if the
subitems are enabled or not, as access to the subitems is not possible
when the parent is disabled.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

This adds a menu item to open the new renderer dialog
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

According to HIG, Command+F shall be used, but as it is already
taken by fullscreen, lets use Command+Shift+F.

refs #13865

This affects main menu and playlist context menu items. Also
removes dead code from the PlaylistView class.

The old VLCIntf macro is deprecated, getIntf() should be used
instead.

Factor and move code entirely to VLCPlaylist.

close #16303

Implementation is the same for both menu items. Menu validation
is used to check before if an item is a local file and existing.
Action is passed from main menu via responder chain to playlist.

Like all other panels.

Uses NSWindowController to load the information panel. Get rid of
the singleton. VLCMain will now hold one instance, which is aimed
to display information about the currently playing media.

This renames the playlist related class files to match the class name,
which makes it easier to find the which belongs to a certain class and
follows common Cocoa/Obj C file naming conventions.
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>

Also deinitalizes both objects. This should fix the refcount
crash on exit.

This improves separation between main menu and the unrelated goto
time window.

Besides that, note that each time bindings are used with the file
owner, this owner needs to be an NSWindowController class. Only in
this case retain cycles are avoided (bindings have a strong
reference to the object used).

Thus, this commit helps to properly deinitialize the VLCMain object.

... and get rid of another singleton.