Skip to content

GitLab

V
vlc
Switch branch/tag
  1. 17 Feb, 2016 2 commits
    • Hugo Beauzée-Luyssen's avatar
      upnp: Fetch the server icon · 0cff5611
      Hugo Beauzée-Luyssen authored
      0cff5611
    • Filip Roséen's avatar
      nothrow new in cases where it maches intent · 1bed74fe
      Filip Roséen authored 
      I wrote a hackish script to locate instances where new can throw
but where the original author has assumed that it will return
nullptr when there is a memory allocation problem.

In short, cases such as `ptr = new T; if (ptr) ...` has now
been changed to `ptr = new (std::nothrow) T; if (ptr) ...`.

Since a throwing `new` will always yield a non-nullptr pointer,
code that follows similar patterns to the previous example are
therefor redundant.

Example (from modules/access/dshow/filter.cpp):

    *ppEnum = new CaptureEnumMediaTypes( p_input, p_pin, this );

    if( *ppEnum == NULL )
      return E_OUTOFMEMORY; // unreachable, new will never return NULL

Fixed:

    *ppEnum = new (std::nothrow) CaptureEnumMediaTypes( p_input, p_pin, this );

    if( *ppEnum == NULL )
      return E_OUTOFMEMORY;
Signed-off-by: Hugo Beauzée-Luyssen's avatarHugo Beauzée-Luyssen <hugo@beauzee.fr>
      1bed74fe
  3. 16 Feb, 2016 3 commits
  5. 15 Feb, 2016 11 commits
  7. 14 Feb, 2016 6 commits
  9. 13 Feb, 2016 10 commits
  11. 12 Feb, 2016 8 commits