Commit ca6b633e authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont

Remove error/warnings from module_need()

They caused much confusion from bug reporters and support requestors.
Feel free to add more explicit and specific errors after module_need()
call sites in failure cases.
parent 4cd022e6
...@@ -590,30 +590,11 @@ found_shortcut: ...@@ -590,30 +590,11 @@ found_shortcut:
: p_module->psz_object_name ); : p_module->psz_object_name );
} }
else if( count == 0 ) else if( count == 0 )
{ msg_Dbg( p_this, "no %s module matched \"%s\"",
if( !strcmp( psz_capability, "access_demux" )
|| !strcmp( psz_capability, "stream_filter" )
|| !strcmp( psz_capability, "vout_window" ) )
{
msg_Dbg( p_this, "no %s module matched \"%s\"",
psz_capability, (psz_name && *psz_name) ? psz_name : "any" );
}
else
{
msg_Err( p_this, "no %s module matched \"%s\"",
psz_capability, (psz_name && *psz_name) ? psz_name : "any" );
msg_StackSet( VLC_EGENERIC, "no %s module matched \"%s\"",
psz_capability, (psz_name && *psz_name) ? psz_name : "any" ); psz_capability, (psz_name && *psz_name) ? psz_name : "any" );
}
}
else if( psz_name != NULL && *psz_name )
{
msg_Warn( p_this, "no %s module matching \"%s\" could be loaded",
psz_capability, (psz_name && *psz_name) ? psz_name : "any" );
}
else else
msg_StackSet( VLC_EGENERIC, "no suitable %s module", psz_capability ); msg_Dbg( p_this, "no %s module matching \"%s\" could be loaded",
psz_capability, (psz_name && *psz_name) ? psz_name : "any" );
free( psz_shortcuts ); free( psz_shortcuts );
free( psz_var ); free( psz_var );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment