Commit 88ae87b2 authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont

RTMP: tag some of the obvious bugs

parent 600ceaf9
...@@ -351,8 +351,10 @@ static ssize_t Read( access_t *p_access, uint8_t *p_buffer, size_t i_len ) ...@@ -351,8 +351,10 @@ static ssize_t Read( access_t *p_access, uint8_t *p_buffer, size_t i_len )
if( !p_sys->p_thread->metadata_received ) if( !p_sys->p_thread->metadata_received )
{ {
/* Wait until enough data is received for extracting metadata */ /* Wait until enough data is received for extracting metadata */
#warning This is not thread-safe (because block_FifoCount() is not)!
if( block_FifoCount( p_sys->p_thread->p_fifo_input ) < 10 ) if( block_FifoCount( p_sys->p_thread->p_fifo_input ) < 10 )
{ {
#warning This is wrong!
msleep(100000); msleep(100000);
continue; continue;
} }
...@@ -549,6 +551,7 @@ static void* ThreadControl( vlc_object_t *p_this ) ...@@ -549,6 +551,7 @@ static void* ThreadControl( vlc_object_t *p_this )
/* Sometimes server close connection too soon */ /* Sometimes server close connection too soon */
if( p_thread->result_connect ) if( p_thread->result_connect )
{ {
#warning There must be a bug here!
vlc_mutex_lock( &p_thread->lock ); vlc_mutex_lock( &p_thread->lock );
vlc_cond_signal( &p_thread->wait ); vlc_cond_signal( &p_thread->wait );
vlc_mutex_unlock( &p_thread->lock ); vlc_mutex_unlock( &p_thread->lock );
......
...@@ -1277,6 +1277,7 @@ rtmp_handler_invoke( rtmp_control_thread_t *p_thread, rtmp_packet_t *rtmp_packet ...@@ -1277,6 +1277,7 @@ rtmp_handler_invoke( rtmp_control_thread_t *p_thread, rtmp_packet_t *rtmp_packet
msg_Dbg( p_thread, "key: %s value: %s", string, string2 ); msg_Dbg( p_thread, "key: %s value: %s", string, string2 );
if( strcmp( "code", string ) == 0 ) if( strcmp( "code", string ) == 0 )
{ {
#warning Locking bugs here.
if( strcmp( "NetConnection.Connect.Success", string2 ) == 0 ) if( strcmp( "NetConnection.Connect.Success", string2 ) == 0 )
{ {
p_thread->result_connect = 0; p_thread->result_connect = 0;
......
...@@ -404,6 +404,7 @@ static void* ThreadControl( vlc_object_t *p_this ) ...@@ -404,6 +404,7 @@ static void* ThreadControl( vlc_object_t *p_this )
else else
{ {
/* Sometimes server close connection too soon */ /* Sometimes server close connection too soon */
#warning Locking bug here.
if( p_thread->result_connect ) if( p_thread->result_connect )
{ {
vlc_mutex_lock( &p_thread->lock ); vlc_mutex_lock( &p_thread->lock );
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment