Commit 662f12f4 authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont

http: remove secure flag for setting cookies (refs #16174)

This is only necessary for getting cookies as per the specification.
parent bae60ab2
...@@ -82,7 +82,7 @@ VLC_API void vlc_http_cookies_destroy( vlc_http_cookie_jar_t * p_jar ); ...@@ -82,7 +82,7 @@ VLC_API void vlc_http_cookies_destroy( vlc_http_cookie_jar_t * p_jar );
* @return true, if the cookie was added, false otherwise * @return true, if the cookie was added, false otherwise
*/ */
VLC_API bool vlc_http_cookies_store( vlc_http_cookie_jar_t *jar, VLC_API bool vlc_http_cookies_store( vlc_http_cookie_jar_t *jar,
const char *cookie, bool secure, const char *host, const char *path ); const char *cookie, const char *host, const char *path );
/** /**
* Returns a cookie value that match the given URL. * Returns a cookie value that match the given URL.
......
...@@ -902,7 +902,7 @@ uintmax_t vlc_http_msg_get_size(const struct vlc_http_msg *m) ...@@ -902,7 +902,7 @@ uintmax_t vlc_http_msg_get_size(const struct vlc_http_msg *m)
} }
void vlc_http_msg_get_cookies(const struct vlc_http_msg *m, void vlc_http_msg_get_cookies(const struct vlc_http_msg *m,
vlc_http_cookie_jar_t *jar, bool secure, vlc_http_cookie_jar_t *jar,
const char *host, const char *path) const char *host, const char *path)
{ {
if (jar == NULL) if (jar == NULL)
...@@ -910,7 +910,7 @@ void vlc_http_msg_get_cookies(const struct vlc_http_msg *m, ...@@ -910,7 +910,7 @@ void vlc_http_msg_get_cookies(const struct vlc_http_msg *m,
for (unsigned i = 0; i < m->count; i++) for (unsigned i = 0; i < m->count; i++)
if (!strcasecmp(m->headers[i][0], "Set-Cookie")) if (!strcasecmp(m->headers[i][0], "Set-Cookie"))
vlc_http_cookies_store(jar, m->headers[i][1], secure, host, path); vlc_http_cookies_store(jar, m->headers[i][1], host, path);
} }
int vlc_http_msg_add_cookies(struct vlc_http_msg *m, int vlc_http_msg_add_cookies(struct vlc_http_msg *m,
......
...@@ -143,7 +143,7 @@ time_t vlc_http_msg_get_mtime(const struct vlc_http_msg *); ...@@ -143,7 +143,7 @@ time_t vlc_http_msg_get_mtime(const struct vlc_http_msg *);
unsigned vlc_http_msg_get_retry_after(const struct vlc_http_msg *); unsigned vlc_http_msg_get_retry_after(const struct vlc_http_msg *);
void vlc_http_msg_get_cookies(const struct vlc_http_msg *, void vlc_http_msg_get_cookies(const struct vlc_http_msg *,
struct vlc_http_cookie_jar_t *, bool secure, struct vlc_http_cookie_jar_t *,
const char *host, const char *path); const char *host, const char *path);
int vlc_http_msg_add_cookies(struct vlc_http_msg *, int vlc_http_msg_add_cookies(struct vlc_http_msg *,
struct vlc_http_cookie_jar_t *); struct vlc_http_cookie_jar_t *);
......
...@@ -99,7 +99,7 @@ retry: ...@@ -99,7 +99,7 @@ retry:
return NULL; return NULL;
vlc_http_msg_get_cookies(resp, vlc_http_mgr_get_jar(res->manager), vlc_http_msg_get_cookies(resp, vlc_http_mgr_get_jar(res->manager),
res->secure, res->host, res->path); res->host, res->path);
int status = vlc_http_msg_get_status(resp); int status = vlc_http_msg_get_status(resp);
if (status < 200 || status >= 599) if (status < 200 || status >= 599)
......
...@@ -294,7 +294,7 @@ void vlc_http_cookies_destroy( vlc_http_cookie_jar_t * p_jar ) ...@@ -294,7 +294,7 @@ void vlc_http_cookies_destroy( vlc_http_cookie_jar_t * p_jar )
} }
bool vlc_http_cookies_store(vlc_http_cookie_jar_t *p_jar, const char *cookies, bool vlc_http_cookies_store(vlc_http_cookie_jar_t *p_jar, const char *cookies,
bool secure, const char *host, const char *path) const char *host, const char *path)
{ {
assert(host != NULL); assert(host != NULL);
assert(path != NULL); assert(path != NULL);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment