Qt4: fix a crash (kind of a 'use after free' error).

13c520d1 · Rémi Duraffort · c57caf76 · 13c520d1
Commit 13c520d1 authored Apr 29, 2010 by Rémi Duraffort
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

modules/gui/qt4/menus.cpp modules/gui/qt4/menus.cpp +1 -1

No files found.
--- a/modules/gui/qt4/menus.cpp
+++ b/modules/gui/qt4/menus.cpp
@@ -439,9 +439,9 @@ QMenu *QVLCMenu::ViewMenu( intf_thread_t *p_intf, QMenu *current, MainInterface
        foreach( QAction *a, actions )
        {
            QMenu *m = a->menu();
-            if( m && m->parent() == menu ) delete m;
            if( a->parent() == menu ) delete a;
            else menu->removeAction( a );
+            if( m && m->parent() == menu ) delete m;
        }
    }