We can't use vlc_stream_NewURL as it will include the skiptags filter

Since the only part that matters to taglib is the filename, and more
specifically the extension part.

Thomas Guillem authored Feb 07, 2019 and Hugo Beauzée-Luyssen committed Oct 11, 2019

As they are extremely likely to be read already

The autoconf endianness check does not compile with a C++ compiler
due to bogus casts, therefore it is needed to use the C compiler to
check for the host endianness.

This fixes the libmodplug contrib build for Android.

These backslashes would actually end up in the documentations
code block and are not needed here.

On linux, -lslang was not added on LDLIB

Fixes #17251

This fixes -lz that is not added in ldlib on linux.

Refs #17251

Rémi Denis-Courmont authored Oct 08, 2019 and Thomas Guillem committed Oct 10, 2019

It does not compile.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Rémi Denis-Courmont authored Oct 08, 2019 and Thomas Guillem committed Oct 10, 2019

Otherwise it is autodetected, which leads to nonreproducible builds:
depending if GLUT is available or not, OpenGL is enabled or not.

This also might fix #20543 (cannot be verified due to #17251).

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Previously, the original linker generated import libraries were
copied into the lib directory with names "libvlc.lib" and
"libvlccore.lib", only to be overwritten by dlltool in the next
step.

The duplication appeared in ab72243a; before that, the files
were copied keeping their original names.

Later, 4ab7dfbf added import libraries containing only linker
script, with names vlc.lib and vlccore.lib (which are picked up by
GNU ld but are an uncommon naming pattern for mingw libraries), as
a convenience for mingw toolchains, being able to only specify
-lvlc -lvlccore.

Instead of providing libraries (with the intention of being used
by mingw tools) with the more foreign (to mingw) names "vlc.lib"
and "vlccore.lib", name them "libvlc.dll.a" and "libvlccore.dll.a",
and make them a copy of the dlltool generated import library instead
of being a linker script (for compatibility with lld).

Instead of an unprotected plain integer

If there is no display, there is no thread and vout_control_Hold() will wait
indefinitely.

Not fixing anything since this control struct is allocated from the
vlc_object_t that is 0ed.

It's already set to NULL above if it wasn't NULL.

For example if the vout didn't start properly.