Commit 981f1446 authored by Soomin Lee's avatar Soomin Lee

CustomDialogRendererHandler: Disable SMBv1 dialog

This disables the overall SMBv1/SMBv2 dialog logic introduced by
a5476b4f.

Indeed, due to a keystore issue the user will be asked/spammed everytime
for a SMB version confirmation.

This SMBv1 dialog need a permanent keystore to remember the user choice.
Sadly, we can't really add the keychain keystore until a major network
browsing rework.

Some functionalities are missing like the ability to edit/remove keystore entries.
parent adfda5dc
......@@ -153,26 +153,33 @@ extension CustomDialogRendererHandler: VLCCustomDialogRendererProtocol {
func showLogin(withTitle title: String, message: String,
defaultUsername username: String?, askingForStorage: Bool,
withReference reference: NSValue) {
if !title.contains("SMBv1") || selectedSMBv1 {
handleLoginAlert(with: title, message: message,
username: username,
askingForStorage: askingForStorage,
withReference: reference)
return
}
handleSMBv1() {
[weak self] isSMBv1 in
if isSMBv1 {
self?.selectedSMBv1 = true
self?.handleLoginAlert(with: title, message: message,
username: username,
askingForStorage: askingForStorage,
withReference: reference)
} else {
self?.dialogProvider.dismissDialog(withReference: reference)
}
}
// Due to a keystore issue, we disable the overall SMBv1 dialog logic and direcly show the login
handleLoginAlert(with: title, message: message,
username: username,
askingForStorage: false,
withReference: reference)
// if !title.contains("SMBv1") || selectedSMBv1 {
// handleLoginAlert(with: title, message: message,
// username: username,
// askingForStorage: askingForStorage,
// withReference: reference)
// return
// }
// handleSMBv1() {
// [weak self] isSMBv1 in
// if isSMBv1 {
// self?.selectedSMBv1 = true
// self?.handleLoginAlert(with: title, message: message,
// username: username,
// askingForStorage: askingForStorage,
// withReference: reference)
// } else {
// self?.dialogProvider.dismissDialog(withReference: reference)
// }
// }
}
func showQuestion(withTitle title: String, message: String,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment