- 09 Aug, 2021 23 commits
-
-
-
-
-
-
-
-
-
-
- documented parameters need to appear in the prototype. - offset was probably a leftover from copy-paste.
-
- functions returning void with a \return is incorrect. - missing documented parameter names in the prototypes. - copy-paste leftover for vlc_playlist_SetPlaybackOrder. - vlc_playlist_Preparse doesn't need a libvlc instance.
-
- missing documented parameter names. - void functions with a \return parameter is incorrect. - non-matching parameter names and documented parameters. - player_rate doesn't exist in vlc_player_timer_point_Interpolate.
-
-
-
-
-
-
-
The callbacks and opaque seem to have been replaced by a whole owner object.
-
If the parameter is documented in the prototype, it should be specified in the prototype and should not be left out.
-
- \param is used to declare a parameter, so \p should be used to reference them. - `type` parameter didn't exist. - `opaque` parameter was named `data` - \return for void functions is not correct. Moving the notice to a \bug reference. - \see used instead of \ref.
-
Doxygen and other clients will complain.
-
-
-
- 08 Aug, 2021 12 commits
-
-
This fixes subtitle texts are not shown correctly on OS/2. Freetype module expects UCS-4 string. However, OS/2 iconv() does not support UCS-4 encoding, so UCS-2 encoding is used on OS/2. Because of this mis-match, subtitle texts on OS/2 are mis-interpreted. As a result, subtitle texts are not shown correctly.
-
the cpu SIMD selection code removed here dates from a time when vlc had options for disabling use of select SIMD variants, from before postproc added cpu auto-detection ([1]), and from before postproc seems to have added SSE2 ([2] and [3]). we are purging MMX/MMXEXT from vlc v4.0-dev, and thus have an interest in removing the corresponding MMX/MMXEXT bits here. rather than just removing those lines, alongside adding an entry for SSE2 though, i have instead chosen to convert the code to use auto-detection, which avoids having to keep the block of code explicitly enabling implementations in sync with the set of implementations available. note, the version of postproc in contribs is very old, pre-dating the SSE2 and CPU feature auto-detection enhancements. accordingly i have had to ensure that we define `PP_CPU_CAPS_AUTO` ourselves when not found, as had been done for `PP_CPU_CAPS_ALTIVEC`. effectively, for users like myself on linux with a new enough version, the auto-detection will work correctly and now make use of SSE2, which we were ignoring before; while where the contrib package is used, its use will fall back to the C implementation until such time that the contrib gets updated. [1]: https://github.com/FFmpeg/FFmpeg/commit/59d686f100863d00b8f171dd891e893c2bfd951e [2]: https://github.com/FFmpeg/FFmpeg/commit/4e264d1c79cfae8c3e05aacf77e350ed1b6d7e4b [3]: https://github.com/FFmpeg/FFmpeg/commit/f48cddfe4cf04e2d6e802d12e973301ff5a1a9a8
-
-
-
-
-
-
-
the `NeAACDecSetConfiguration()` function copies attributes from the given config object to the actual config held within the decoder context object. it validates each config attribute before copying it, immediately returning zero if the attribute is invalid. we should use the return value to check that our config was successfully written.
-
-
'parsingPending' property is not available with NetworkDevicesModel
-
'model' in this scope referred to the attached property i.e NetworkGridItem.ListView.model, replace it with the correct source model i.e 'deviceModel'
-
- 07 Aug, 2021 1 commit
-
-
`size` counts both actual options **and** hint entries within option sets. `count` only counts the actual options. we are only interested in the actual options here, so we should use `count` to allocate only the memory we actually need. this avoids allocating roughly 1000 pointers' worth of unused space. the addition of the assert was requested in review.
-
- 06 Aug, 2021 4 commits
-
-
fix: #25911
-
fix: #25486
-
-
ensure that the platform is able to use direct composition and can use shared textures before initialising it. fix: #24847
-
