GitLab

VLCPlaybackController:send notifications about playback state change when libvlc actually changed it

The notifications were sent too early which caused a wrong determination of isPlaying state in the VLCPlayerDisplayController who observed these
This led to a bug where media was actually playing but there were no controls to actually pause or stop the playback

The layoutGuides can be nil and crashh for <iOS 11 so we need to use self

In iOS 9 and 10 there might not be a Layoutguide and the constraints would cause a crash when guide was set to nil

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

This removes the confusion between screen brightness and video
filter brightness. Hence, it fixes the position of the brightness silder
position on a start of a media.
Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Since we're having two xibs for iPhone and iPad this block was necessary since the trackselector
on iPhone was previously displayed in the bottom of the phone, overlapped by the controls.
With the refactor we don't need device specific behavior anymore since the controls always appear centered on screen

When updateMetadataFromMediaPlayer was called not all fields were overwritten before
This led to titles not being hidden because the metadata had isAudioonly set from previous use.

The title was pinned to the top with 800 pixel more.
On iPad in landscape (height 720 )it was placed outside the views bounds
It's now placed in relation to the bottom of the view

The albumartwork was above the movieview in the viewhierachy on iPad so we moved it underneath it

VLC will now appear in the Files app under my iPhone. User shortcut into VLC from this entry point (closes #19157)

(cherry picked from commit e7c01a34)

(cherry picked from commit a6d0a2c2)

Since the delegate is being overwritten by the currently playing view it needs
to be set again every time the view reappears to receive updates.

Set label leading anchors to image trailing to adjust for different image sizes and set the label trailing anchors to the leading downloadbutton

When viewing local network files there was an issue where if the folder/file name was extremely long, the text would cover the download button making it difficult to see. This fixes that issue by updating the constraints in VLCNetworkList.xib and adding the [super prepareForReuse]; call in the cell class.
Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

(cherry picked from commit 8e0152ab)

VLCDragAndDrop: dragging Albums and Shows into Folder is now forbidden, corrected a typo, on iOS11 don't use the reorderlayout in folders since we have drag and drop, corrected dragging shows somewhere else

(cherry picked from commit 8aae18ec)

VLCMovieViewController: toggle between filltoCrop and previous aspect ratio for double tap on iPhoneX and refactored the aspect ratio code

(cherry picked from commit 9469da72)

(cherry picked from commit b03efc36)

VLCMovieViewController: adjust the trackselector width constraint so that it is never too big for the screen

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>