Benjamin Arnaud authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Co-authored-by: Pierre Lamot <pierre@videolabs.io>

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

It's already included by config.h

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The commit ca7d2ea4 introduced an xyzw
swizzle, whereas the previous code was using an rgba swizzle. No other
location used the xyzw swizzle for texture so unify and use rgba
everywhere.

Different version from aa5bec3b

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

GL_LUMINANCE_ALPHA textures should be sampled through r and a swizzle
since it has a `(L,L,L,A)` layout.

This reverts commit 05f29287.

Fixes #26767
Reintroduce #26735

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The swizzle of the texture should be different between
GL_LUMINANCE_ALPHA textures and GL_RG textures.

This reverts commit aa5bec3b.

Refs #26767

Felix Paul Kühne authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

This adds an additional info line to match the IPv6 implementation.

Prince Gupta authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

fixup 4e2f8238

Lyndon Brown authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

inconsistent with that used in `coverartarchive_make_releasegroup_arturl()`.

i believe that with-dash is likely the correct form, since firstly, that
function is actually used unlike this one, and this function was also
fundamentally broken before the previous commit. also secondly, the info
at [1] seems to indicate that with-dash is correct.

[1]: https://github.com/Borewit/musicbrainz-api

Lyndon Brown authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

and fix leak with the corrected logic.

Thomas Guillem authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

volume is valid only if !bitexact.

Thomas Guillem authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

It's really weird to call functions with a NULL pointer...

Thomas Guillem authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Relaxed because we don't need synchronisation with other variables.

gain_factor and output_factor are write from different threads, so a
sequentially consistent ordering won't help.

Thomas Guillem authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

 - output_factor is read from aout_volume_Amplify(), called from the
input/decoder.c DecoderThread.

 - output_factor is written from aout_volume_SetVolume(). It is either
   called  from the same thread via the start cb (OK in that case) or
   from any threads via the volume_set cb.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This is essentially the same as timespec_to_vlc_tick() but it does not
clobber the namespace, so it can be exported.

Thomas Guillem authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

All aout users can trigger a destroy, when releasing, if the refcount
reaches 0.

This will allow having more than one aout users (stream from decoder.c),
for gapless and later for multiple streams playback. Indeed, you prefer
not to destroy the aout from one decoder, while used by another decoder.

Pierre Lamot authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

It is a common design language to have the record button red.

The animation provides a visual feedback when the user is currently recording.

Felix Paul Kühne authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

This introduces a patch to fix compilation on AArch64 on AppleOS, which
currently fails due to a compiler flag used by gnutls that is
unsupported by the latest version of clang (Apple clang version 13.1.6,
clang-1316.0.21.2) leading to a compiler crash if used.

This resolves the upstream tickets
https://gitlab.com/gnutls/gnutls/-/issues/1347 and
https://gitlab.com/gnutls/gnutls/-/issues/1317 for which the same patch
was already suggested.

Pierre Lamot authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

having the three models always present, means that the data (at least the first
chuck) is loaded 3 times, and will be reloaded 3 times every time a database
event triggers a refresh of the model.

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

CFLAGS is added to the linker flags and newer LLVM don't like that.
CPPFLAGS is used during C compilation and C++ but not added to LDFLAGS.