This is the final cleanup of the codebase
- Added pragma-marks to the classes for more readability
- Reordered code in mainWindow in favour to the pragma-marks

Make and use only one instance of dataModel for showing items inside libraryView
Following changes were introduced with this
 - This fixes the regression of 264754b3
 - Also now the performance of loading is increased a bit
 - Did a minor cleanup of VLCMainWindow
 - Also fixes the issue of not laoding thumbnail and videoTitle inside popOver

During initial development of libraryView we made the cocoa classes names with
non-standerized names without proper Naming Conventions
VLCMainWindowCollectionViewItem -> VLCLibraryView
VLCMainWindowDataModel -> VLCLibraryItem

Earlier we had 3 diffrent dataModel for thumbinail,image and years,now we have only one
dataModel

To-Do
 - Currently values is added to array which is being replaced instead of adding which
dataModel to repeat valeus
 - Fix up passing the dataModel to collectionViewItem

This commit fully revamp the current implementation of the dummyData with proper Guidelines
of MVC so now the data is made into a datamModel and passed to
VLCMainWindowCollectionViewItem with assignValueForDataModel with dataModel as an argument

Felix Paul Kühne authored Jun 27, 2018 and Vibhoothi committed Aug 07, 2018

This fixes a regression introduced in a6e1e1b0

Cleaned up the VLCMainWinodw class

This commit fixes the typos and all other issues of the colletionViewItems like
   - Wrong Dimensions of items
   - Wrong flowLayout item size
   - Add and remove few missing constraints

This commits adds a new dataModel to the VLC which essentailly brings us the Model View
Controller concept ie. seperates dataModel from View and Controlle
The following are the changes introuduced with this commitr
  - Add Cocoa class VLCMainWindowDataModel which is the dataModel for us
  - Build the dataModel
  - Make changes to the VLC Xcode Project to adapt to the new change

This commit fixses most of constraints issue found in the collectionViewItem's IB

Introduces thumbinails to VLC's libraryView which is now loaded from local directory since
its now using dummyData only not using CoreAPIs.
This commit also introduces videoTitle field below to video thumbinail in libraryView

This commit introduces a minimal popOver with a button into the collectionView aka
LibraryView which shows all metaData informationd of the video when user clicks the button
found in collectionViewItem

- Loads the image from default location which is hardcoded as of now using NSColelctionVIewDataSource and NSFileManager.
- Uses FlowLayout for showing the items in the collectionView
- Shows Highlight of selection with blue colour (alternateSelectedControlColor).
- Get the index of selection using delegate following NSCollectionViewDelegate protocol and for debugging and all have displayed the log of it to command line.
- Scrolling function is also there with this, when the user resizes Window,it dynamically resizes the collection view items

From VLC 4.0 we are making 10.11 macOS version as minimum specification for having
libraryView feature and for all who are below 10.11 will have normal VLC without libraryView
feature

This introduction is for making libraryView based on NSCollectionView by default for VLC 4.0
The following files are newly introduced
 - VLCMainWindowCollectionViewItem.xib : An Interface for showing collectionView items.
 - VLCMainWindowCollectionViewItem.h   : Header file for defining instance and instance variables
 - VLCMainWindowCollectionViewItem.m   : Cococa class which contains implementation of instance and representation of objects
-  Build VLCMainWindowCollectionViewItem files

This commit introduces various changes to current VLC Xcode project which is essential
for future development.Also few are done as per Xcode Specification

macosx: add a basic collection view for future implementation while retaining the current main window behavior

Vibhoothi authored Jun 10, 2018 and Felix Paul Kühne committed Jun 10, 2018

This is part of first steps in making the Library view

Vibhoothi authored Jun 10, 2018 and Felix Paul Kühne committed Jun 10, 2018

This is part of first steps in making the Library view

Vibhoothi authored Jun 10, 2018 and Felix Paul Kühne committed Jun 10, 2018

This is part of first steps in making the Library view

Vibhoothi authored Jun 09, 2018 and Felix Paul Kühne committed Jun 10, 2018

This is part of first steps in making the Library view

This should be able to be just replace the old NSUInteger, according
to docs.

Access to those will be removed in a future update of macOS

Access to those will be removed in a future update of macOS