Commit 7531cecf authored by Sean Robinson's avatar Sean Robinson Committed by Mirsal Ennaime

dbus: Return an int64 in the Position property getter

According to the MPRIS specification, the Position property of the
Player object must be an int64.

dbus microsecond position overflows the unsigned 32-bit integer at
about 35:48 into a track's playback.  A 64-bit integer still means
an overflow, but after more than 292000 years into a track's playback.
Signed-off-by: Mirsal Ennaime's avatarMirsal Ennaime <>
parent 344a19dc
......@@ -45,9 +45,9 @@ DBUS_METHOD( Position )
DBusMessageIter v;
dbus_int32_t i_pos;
dbus_int64_t i_pos;
if( !dbus_message_iter_open_container( &args, DBUS_TYPE_VARIANT, "i", &v ) )
if( !dbus_message_iter_open_container( &args, DBUS_TYPE_VARIANT, "x", &v ) )
input_thread_t *p_input = playlist_CurrentInput( PL );
......@@ -61,7 +61,7 @@ DBUS_METHOD( Position )
vlc_object_release( p_input );
if( !dbus_message_iter_append_basic( &v, DBUS_TYPE_INT32, &i_pos ) )
if( !dbus_message_iter_append_basic( &v, DBUS_TYPE_INT64, &i_pos ) )
if( !dbus_message_iter_close_container( &args, &v ) )
......@@ -74,7 +74,7 @@ DBUS_METHOD( SetPosition )
{ /* set position in microseconds */
dbus_int32_t i_pos;
dbus_int64_t i_pos;
vlc_value_t position;
char *psz_trackid, *psz_dbus_trackid;
input_item_t *p_item;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment