Commit 7b525047 authored by Erwan Tulou's avatar Erwan Tulou

skins2: improve fullscreen behaviour

At the core level, the 'f' hotkey and the double click are managed in a
slightly different way. The former sets up both the playlist and the vout
"fullscreen" variables whereas the latter only sets up the vout variable.

This patch first relies on the vout state if any, and falls back to the
playlist state. This ensures that the fullscreen button always works
consistently for the user. Otherwise, user needs to press twice instead
of once when the playlist and the vout are no longer in sync (after a double
parent 37ae9134
......@@ -30,15 +30,22 @@
void CmdFullscreen::execute()
bool fs = var_ToggleBool( pl_Get( getIntf() ), "fullscreen" );
if( getIntf()->p_sys->p_input == NULL )
vout_thread_t *pVout = input_GetVout( getIntf()->p_sys->p_input );
if( pVout )
bool fs;
bool hasVout = false;
if( getIntf()->p_sys->p_input != NULL )
// Switch fullscreen
var_SetBool( pVout, "fullscreen", fs );
vlc_object_release( pVout );
vout_thread_t *pVout = input_GetVout( getIntf()->p_sys->p_input );
if( pVout )
// Toggle fullscreen
fs = var_ToggleBool( pVout, "fullscreen" );
vlc_object_release( pVout );
hasVout = true;
if( hasVout )
var_SetBool( pl_Get( getIntf() ), "fullscreen", fs );
var_ToggleBool( pl_Get( getIntf() ), "fullscreen" );
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment