Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Menu
Open sidebar
Geoffrey Métais
VLC-Android
Commits
b5a1944c
Commit
b5a1944c
authored
Apr 19, 2018
by
Geoffrey Métais
Browse files
Hide Passthrough option if device cannot do it
parent
10ece049
Changes
3
Hide whitespace changes
Inline
Side-by-side
vlc-android/src/org/videolan/vlc/gui/dialogs/AdvOptionsDialog.java
View file @
b5a1944c
...
@@ -72,6 +72,7 @@ public class AdvOptionsDialog extends DialogFragment implements View.OnClickList
...
@@ -72,6 +72,7 @@ public class AdvOptionsDialog extends DialogFragment implements View.OnClickList
public
final
static
String
TAG
=
"VLC/AdvOptionsDialog"
;
public
final
static
String
TAG
=
"VLC/AdvOptionsDialog"
;
public
static
final
String
MODE_KEY
=
"mode"
;
public
static
final
String
MODE_KEY
=
"mode"
;
public
static
final
String
PRIMARY_DISPLAY
=
"primary_display"
;
public
static
final
String
PRIMARY_DISPLAY
=
"primary_display"
;
public
static
final
String
PASSTHROUGH
=
"passthrough"
;
public
static
final
int
MODE_VIDEO
=
0
;
public
static
final
int
MODE_VIDEO
=
0
;
public
static
final
int
MODE_AUDIO
=
1
;
public
static
final
int
MODE_AUDIO
=
1
;
...
@@ -97,7 +98,8 @@ public class AdvOptionsDialog extends DialogFragment implements View.OnClickList
...
@@ -97,7 +98,8 @@ public class AdvOptionsDialog extends DialogFragment implements View.OnClickList
private
Activity
mActivity
;
private
Activity
mActivity
;
private
int
mMode
=
-
1
;
private
int
mMode
=
-
1
;
private
boolean
primary
;
private
boolean
mPrimary
;
private
boolean
mPassthrough
;
AutoFitRecyclerView
mRecyclerView
;
AutoFitRecyclerView
mRecyclerView
;
private
AdvOptionsAdapter
mAdapter
;
private
AdvOptionsAdapter
mAdapter
;
...
@@ -133,7 +135,8 @@ public class AdvOptionsDialog extends DialogFragment implements View.OnClickList
...
@@ -133,7 +135,8 @@ public class AdvOptionsDialog extends DialogFragment implements View.OnClickList
final
Bundle
args
=
getArguments
();
final
Bundle
args
=
getArguments
();
if
(
args
!=
null
)
{
if
(
args
!=
null
)
{
mMode
=
args
.
containsKey
(
MODE_KEY
)
?
args
.
getInt
(
MODE_KEY
)
:
MODE_VIDEO
;
mMode
=
args
.
containsKey
(
MODE_KEY
)
?
args
.
getInt
(
MODE_KEY
)
:
MODE_VIDEO
;
primary
=
args
.
containsKey
(
PRIMARY_DISPLAY
)
&&
args
.
getBoolean
(
PRIMARY_DISPLAY
);
mPrimary
=
args
.
containsKey
(
PRIMARY_DISPLAY
)
&&
args
.
getBoolean
(
PRIMARY_DISPLAY
);
mPassthrough
=
args
.
getBoolean
(
PASSTHROUGH
);
}
}
setStyle
(
DialogFragment
.
STYLE_NO_FRAME
,
0
);
setStyle
(
DialogFragment
.
STYLE_NO_FRAME
,
0
);
mHelper
=
new
PlaybackServiceActivity
.
Helper
(
getActivity
(),
this
);
mHelper
=
new
PlaybackServiceActivity
.
Helper
(
getActivity
(),
this
);
...
@@ -552,11 +555,11 @@ public class AdvOptionsDialog extends DialogFragment implements View.OnClickList
...
@@ -552,11 +555,11 @@ public class AdvOptionsDialog extends DialogFragment implements View.OnClickList
mAdapter
.
addOption
(
new
Option
(
ID_EQUALIZER
,
R
.
attr
.
ic_equalizer_normal_style
,
getString
(
R
.
string
.
equalizer
)));
mAdapter
.
addOption
(
new
Option
(
ID_EQUALIZER
,
R
.
attr
.
ic_equalizer_normal_style
,
getString
(
R
.
string
.
equalizer
)));
if
(
mMode
==
MODE_VIDEO
)
{
if
(
mMode
==
MODE_VIDEO
)
{
if
(
p
rimary
&&
!
tvUi
&&
mService
.
getAudioTracksCount
()
>
0
)
if
(
mP
rimary
&&
!
tvUi
&&
mService
.
getAudioTracksCount
()
>
0
)
mAdapter
.
addOption
(
new
Option
(
ID_PLAY_AS_AUDIO
,
R
.
attr
.
ic_playasaudio_on
,
getString
(
R
.
string
.
play_as_audio
)));
mAdapter
.
addOption
(
new
Option
(
ID_PLAY_AS_AUDIO
,
R
.
attr
.
ic_playasaudio_on
,
getString
(
R
.
string
.
play_as_audio
)));
mAdapter
.
addOption
(
new
Option
(
ID_SPU_DELAY
,
R
.
attr
.
ic_subtitledelay
,
getString
(
R
.
string
.
spu_delay
)));
mAdapter
.
addOption
(
new
Option
(
ID_SPU_DELAY
,
R
.
attr
.
ic_subtitledelay
,
getString
(
R
.
string
.
spu_delay
)));
mAdapter
.
addOption
(
new
Option
(
ID_AUDIO_DELAY
,
R
.
attr
.
ic_audiodelay
,
getString
(
R
.
string
.
audio_delay
)));
mAdapter
.
addOption
(
new
Option
(
ID_AUDIO_DELAY
,
R
.
attr
.
ic_audiodelay
,
getString
(
R
.
string
.
audio_delay
)));
if
(
p
rimary
&&
(!
tvUi
||
AndroidDevices
.
hasPiP
)
&&
!
AndroidDevices
.
isDex
(
getActivity
()))
if
(
mP
rimary
&&
(!
tvUi
||
AndroidDevices
.
hasPiP
)
&&
!
AndroidDevices
.
isDex
(
getActivity
()))
mAdapter
.
addOption
(
new
Option
(
ID_POPUP_VIDEO
,
R
.
attr
.
ic_popup_dim
,
getString
(
R
.
string
.
popup_playback_title
)));
mAdapter
.
addOption
(
new
Option
(
ID_POPUP_VIDEO
,
R
.
attr
.
ic_popup_dim
,
getString
(
R
.
string
.
popup_playback_title
)));
mAdapter
.
addOption
(
new
Option
(
ID_REPEAT
,
R
.
attr
.
ic_repeat
,
getString
(
R
.
string
.
repeat_title
)));
mAdapter
.
addOption
(
new
Option
(
ID_REPEAT
,
R
.
attr
.
ic_repeat
,
getString
(
R
.
string
.
repeat_title
)));
if
(
mService
.
canShuffle
())
if
(
mService
.
canShuffle
())
...
@@ -571,7 +574,7 @@ public class AdvOptionsDialog extends DialogFragment implements View.OnClickList
...
@@ -571,7 +574,7 @@ public class AdvOptionsDialog extends DialogFragment implements View.OnClickList
}
else
{
}
else
{
mAdapter
.
addOption
(
new
Option
(
ID_SAVE_PLAYLIST
,
R
.
attr
.
ic_save
,
getString
(
R
.
string
.
playlist_save
)));
mAdapter
.
addOption
(
new
Option
(
ID_SAVE_PLAYLIST
,
R
.
attr
.
ic_save
,
getString
(
R
.
string
.
playlist_save
)));
}
}
if
(
"0"
.
equals
(
prefs
.
getString
(
"aout"
,
"0"
)))
if
(
mPassthrough
&&
"0"
.
equals
(
prefs
.
getString
(
"aout"
,
"0"
)))
mAdapter
.
addOption
(
new
Option
(
ID_PASSTHROUGH
,
R
.
attr
.
ic_passthrough
,
getString
(
R
.
string
.
audio_digital_title
)));
mAdapter
.
addOption
(
new
Option
(
ID_PASSTHROUGH
,
R
.
attr
.
ic_passthrough
,
getString
(
R
.
string
.
audio_digital_title
)));
setDialogDimensions
(
large_items
);
setDialogDimensions
(
large_items
);
}
}
...
...
vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java
View file @
b5a1944c
...
@@ -3105,6 +3105,7 @@ public class VideoPlayerActivity extends AppCompatActivity implements IVLCVout.C
...
@@ -3105,6 +3105,7 @@ public class VideoPlayerActivity extends AppCompatActivity implements IVLCVout.C
final
AdvOptionsDialog
advOptionsDialog
=
new
AdvOptionsDialog
();
final
AdvOptionsDialog
advOptionsDialog
=
new
AdvOptionsDialog
();
final
Bundle
args
=
new
Bundle
(
1
);
final
Bundle
args
=
new
Bundle
(
1
);
args
.
putBoolean
(
AdvOptionsDialog
.
PRIMARY_DISPLAY
,
mDisplayManager
.
isPrimary
());
args
.
putBoolean
(
AdvOptionsDialog
.
PRIMARY_DISPLAY
,
mDisplayManager
.
isPrimary
());
args
.
putBoolean
(
AdvOptionsDialog
.
PASSTHROUGH
,
mService
.
getPlaylistManager
().
getPlayer
().
canDoPassthrough
());
advOptionsDialog
.
setArguments
(
args
);
advOptionsDialog
.
setArguments
(
args
);
advOptionsDialog
.
setOnDismissListener
(
new
DialogInterface
.
OnDismissListener
()
{
advOptionsDialog
.
setOnDismissListener
(
new
DialogInterface
.
OnDismissListener
()
{
@Override
@Override
...
...
vlc-android/src/org/videolan/vlc/media/PlayerController.kt
View file @
b5a1944c
...
@@ -38,6 +38,8 @@ class PlayerController : IVLCVout.Callback, MediaPlayer.EventListener {
...
@@ -38,6 +38,8 @@ class PlayerController : IVLCVout.Callback, MediaPlayer.EventListener {
fun
getVout
():
IVLCVout
?
=
mediaplayer
.
vlcVout
fun
getVout
():
IVLCVout
?
=
mediaplayer
.
vlcVout
fun
canDoPassthrough
()
=
mediaplayer
.
canDoPassthrough
()
fun
getMedia
():
Media
?
=
mediaplayer
.
media
fun
getMedia
():
Media
?
=
mediaplayer
.
media
fun
play
()
{
fun
play
()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment